RedstoneParadox / NiceToHave

Official Repository for the Minecraft mod Nice To Have
GNU Lesser General Public License v3.0
1 stars 1 forks source link

Disabling fertilizer causes composters to not be pullable by hoppers #22

Open campbebj opened 3 years ago

campbebj commented 3 years ago

Nice to have Version 1.3.5

fabric loader version 11.1

fabric api version 30.0

fabric kotlin version 1.4.21

Mod list AFKTape-v1.1.1-Fabric-1.16.3 AllStackable-1.3.0-1.16.x always-drop-loot-4.0.0+mc1.16.1-custom antighost-1.16.4-fabric0.25.1-1.1.3 AnvilFix-1.1.3+build.7-1.16 armoredelytra-1.0.1 automated-crafting-1.3.20+MC1.16.2-1.16.5 autoreconnect-1.1.0 bambootweaks-2.0.0+1.16.1 bedrockify-0.2.1-1.16.2+ beenfo-1.16.4-fabric0.25.1-1.2 bettergraves-0.4.1 block-breakers-0.1 blockus-2.0.2+1.16.4 borderless-mining-1.0.6+1.16.2 cartloaders-0.0.2+1.16.1-0.0.2 cloth-api-1.4.9 config-2-4.8.3 cotton-1.1.0 Couplings-1.3.6 Craftable-Horse-Armour-and-Saddle-Mod-Fabric-1.16.2 custom_hud-1.2.0+1.16.2 dark-loading-screen-1.5.0 dispenser-configurator-1.0.1+MC1.16.4-1.16.5 durabilityviewer-1.16.4-fabric0.25.1-1.10 EditSign-Fabric-1.16.5-2.2.0 elevator_mod-1.0.0 expanded-concrete-0.0.2 expandedstorage-5.6.32+1.16.5 extraalchemy-fabric-1.16.4-1.3.1 fabriblocks-1.2.1 fabric-api-0.30.0+1.16 fabric-carpet-1.16.4-1.4.21+v201216 fabric-chunkpregen-0.3.3 fabric-diagonal-panes-0.4.0 fabric-language-kotlin-1.4.21+build.1 fabriczero-0.2.1 fatxporbs-0.0.9+1.16.4 glassdoor-1.5.0-1.16 grid-1.16.4-fabric0.25.1-1.6.4 grind-enchantments-1.1.3+1.16.3 horizontal-glass-panes-fabric-20w16a horse-stats-vanilla-4.1.4 hotbar-switcher-1.0.4 i-am-very-smart-2.1.0+mc1.16.1 infinityfix-1.1.0 inventory-control-tweaks-1.2.4+MC1.16.2-1.16.5 kiln-1.0.0+1.16.4 lead-villagers-2.1.0+mc1.16.1 leaf-decay-1.2.0-1.16.1 litematica-fabric-1.16.4-0.0.0-dev.20201103.184101 malilib-fabric-1.16.4-0.10.0-dev.21+arne.2 minegate-moreblocks-1.0.2 minihud-fabric-1.16.4-0.19.0-dev.20201103.184029 Mo-Glass-1.5-MC1.16.4 modmenu-1.14.13+build.19 mods more-paths-0.0.3 netherite_horse_armor_v0.4.3_1.16.3 optifabric-1.9.2 OptiFine_1.16.5_HD_U_G6 pal-portalcrafter-2.0.0 pal-portalcrafter-2.0.1 phosphor-fabric-mc1.16.3-0.7.0+build.10 quickshulker-1.1.12-1.16 red-bits-1.6.0 redstone-bits-1.4.0+fabric-1.16.4 repairable-tridents-1.0.0 rer-2.1.3 respawnablepets-1.16.5-1 RoughlyEnoughItems-5.8.10 sep-1.16.2_6 shulkerboxtooltip-2.3.4+1.16.4 shulkerstacker-1.0.0 Stackable+Potions-FABRIC-1.0.0 stairdoors-fabric-2.1.0 tapemouse-1.0.1 unlimiteddragoneggs-1.0.0 unpatch-zero-tick-farms-v1.0.7-1.16.3 WhereIsIt-1.16.5-1.9.2 WI-Zoom-1.3-MC1.16.4 wolves-with-armor-1.5.2-1.16.2 wraith-silkspawners-1.0.1 wrenchable-1.0.0+1.16.1 wrenchanything-1.2.2+20w19a Xaeros_Minimap_21.1.0_Fabric_1.16.5 XaerosWorldMap_1.11.9_Fabric_1.16.5

What happened: Disabling fertilizer causes composters to not be pullable by hoppers when fertilizer is enbaled hopper can pull from the composter fine. when removing just this mod hopper can pull from the composter fine.

Steps to reproduce: Disable fertilizer in config. put a hopper above and below the composter and fill the top with compostable material watch the composter get stuck when it becomes full

I looked at your composter mixing and it looks like you're overriding the Methods even if the fertilizer is disabled, i think you need to have it return bonemeal or call the overridden version when fertilizer is disabled.