Name 'windows' channels the way they should name (

Redth / PushSharp

A server-side library for sending Push Notifications to iOS (iPhone/iPad APNS), Android (C2DM and GCM - Google Cloud Message), Windows Phone, Windows 8, Amazon, Blackberry, and (soon) FirefoxOS devices!

Other

4.38k stars 1.53k forks source link

Name 'windows' channels the way they should name ( #215

Closed gvdhoven closed 8 years ago

gvdhoven commented 11 years ago

The current names (Windows & WindowsPhone) are confusing. Please use the proper acronyms for the channels:

For Windows Phone 8 - Microsoft Push Notification Service (MPNS)
For Windows 8 Desktop or Tablet - Windows Notification Service (WNS)

For instance, currently UrbanAirship tells us for Windows Phone (http://docs.urbanairship.com/build/windows.html#windows-phone-8) that you need a certificate and a private key. However, PushSharp mentions "certificateFilePwd" in the ChannelSettings for Windows which is actually the private key (correct?)

Redth commented 11 years ago

So are you talking about the class names? Eg: WindowsPhonePushChannel to become MicrosoftMpnsChannel and WindowsPushChannel to become MicrosoftWnsChannel ?

Also, PushSharp asks for a certificate which will contain both the public certificate AND the private key. the certificateFilePwd is NOT the private key, rather it is the password for the .pfx or .p12 file which contains the private key (it's very typical to password protect these files that contain the certificate private key in them), so slight difference than it seems you're understanding it...

gvdhoven commented 11 years ago

ehh yes about the names, and sorry about the confusion.