search

Redth / PushSharp

A server-side library for sending Push Notifications to iOS (iPhone/iPad APNS), Android (C2DM and GCM - Google Cloud Message), Windows Phone, Windows 8, Amazon, Blackberry, and (soon) FirefoxOS devices!
Other
4.38k stars 1.52k forks source link

PushSharp for Asp.net Core #776

Open tezine opened 7 years ago

tezine commented 7 years ago

What version of PushSharp are you using?

4.0.10

Describe your issue:

When PushSharp will be available for Asp.net Core?

What are the steps required to reproduce this issue?

Just try to install it into a asp.net core project using nuget

Please provide any Exception Stack Traces

-error: Package PushSharp 4.0.10 is not compatible with netcoreapp1.0 (.NETCoreApp,Version=v1.0). Package PushSharp 4.0.10 supports: net45 (.NETFramework,Version=v4.5) -error: One or more packages are incompatible with .NETCoreApp,Version=v1.0. -Package PushSharp 4.0.10 is not compatible with netcoreapp1.0 (.NETCoreApp,Version=v1.0). Package PushSharp 4.0.10 supports: net45 (.NETFramework,Version=v4.5) -One or more packages are incompatible with .NETCoreApp,Version=v1.0.

ti24horas commented 7 years ago

@tezine could you try to "upgrade" the project to vs2015 project.json format? The majority of the code is compatible with the .netcore version. And its relatively easy to port dependencies to .netcore?

marchy commented 7 years ago

Is there any update on this? We're blocked on migrating to .NET Core because of this. Thx.

ryanlin1986 commented 7 years ago

Since .Net Core 2.0 was out, any update on this?

JRahmatiNL commented 7 years ago

It seems that in .Net Core 2.0 you can refer to certain nuget packages not written using .Net core: see 8th minute in following channel9 video: https://channel9.msdn.com/Blogs/dotnet/NET-Core-20-Released?_lrsc=89a018ae-264d-4f8e-b0f0-abc2bbcf3c78.

I have added the PushSharp nuget package in a .Net core 2.0 experiment project successfully, but haven't tested it yet. I'll try to notify as soon as I do.

JRahmatiNL commented 7 years ago

Seems to work just fine with .Net Core 2.0. Just tested it with a simple sandbox push notification message.

ryanlin1986 commented 7 years ago

Cool, thanks for the info.

marchy commented 7 years ago

This would be wonderful. Don't you just love it when problems fix themselves?? =)

retsetman commented 7 years ago

@gitjafar What type of operating system did the computer you used for the test have? I am interested to know if this new feature of .net core 2.0 works also in linux.

JRahmatiNL commented 7 years ago

@retsetman I don't know about Linux, but I tested this on a Mac so its not a Windows only feature. I assume it will also work in Linux but haven't tested that yet as I don't have a Linux machine.

h3smith commented 7 years ago

I've been running a private port for dotnet core and works fine in Docker (aka linux)

retsetman commented 7 years ago

thanks for the info