search

Redth / ZXing.Net.Mobile

Barcode Scanner for Xamarin.iOS, Xamarin.Android, UWP and Tizen
MIT License
1.07k stars 701 forks source link

ZXing Custom Overlay with Torch buttons #933

Open DwainSnickles opened 4 years ago

DwainSnickles commented 4 years ago

I tried your sample code with custom overlay with toggle torch I couldn't get the flash on I created my own. Created my own and posted here on github. It has independent torch buttons for on and off buttons I include the link here for others hope thats ok? https://github.com/DwainSnickles/ZXing-Scanner-Overlay-with-Torch-Buttons

EmilAlipiev commented 4 years ago

Problem with the sample is HasTorch always returns false even phone supports the torch. you can simply set the ShowFlashButton = true and it will display the overlaybutton and rest is working for me. at least i teste on android.

https://github.com/Redth/ZXing.Net.Mobile/issues/942

thhowl commented 4 years ago

That's not a custom overlay. That's buttons below the default overlay. Pertinent not pandentic, because ZXing specifically has the notion of a Custom Overlay.

DwainSnickles commented 4 years ago

Never claimed it was part of the overlay. It’s a custom overlay with buttons.

On Oct 1, 2020 at 12:43 PM, <Timothee Howland (mailto:notifications@github.com)> wrote:

That's not a custom overlay. That's buttons below the default overlay. Pertinent not pandentic, because ZXing specifically has the notion of a Custom Overlay.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (https://github.com/Redth/ZXing.Net.Mobile/issues/933#issuecomment-702326252), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AGM4AZPM7LFO57EA4R6M2B3SITETZANCNFSM4QCKO4AA).

knocte commented 3 years ago

I tried your sample code with custom overlay with toggle torch I couldn't get the flash on

What version of ZXing.Net.Mobile did you use when you encountered this problem @DwainSnickles ?

DwainSnickles commented 3 years ago

I used zxing.mobile.forms version 3.0.0 beta 5 if you let me know what version you are using I will try to help if needed. Thanks Dwain

DwainSnickles commented 3 years ago

After some thought you may have already set permissions I have listed all my permissions you wont need them all but I will post them here just in case AndroidManifest.xml: For some reason it wont let me copy and paste it shows up in the comment put does not display so I uploaded it as a zip file AndroidManifest.zip

knocte commented 3 years ago

I used zxing.mobile.forms version 3.0.0 beta 5

Can you check if this problem is also existing in stable version 2.4.1 please?

DwainSnickles commented 3 years ago

I tried to go back to 2.41 it may be easier if you send me what you have and I will test it for you

knocte commented 3 years ago

What I have? What do you mean? I didn't reproduce the bug, I'm asking you to add more information to the bug report, that's all.