search

Redth / dotnet-maui-check

.NET MAUI Check tool
MIT License
479 stars 79 forks source link

Add WebView2 check #66

Closed Eilon closed 3 years ago

Eilon commented 3 years ago

I sent a PR to update the MAUI installation docs regarding this: https://github.com/dotnet/docs-maui/pull/48

But if maui-check could make sure WebView2 is installed, that would be even better.

Eilon commented 3 years ago

Here's the doc from WebView about how to detect and/or install WebView2: https://docs.microsoft.com/en-us/microsoft-edge/webview2/concepts/distribution#online-only-deployment

Eilon commented 3 years ago

I logged a separate issue to track adding an option to install WebView2: #68

jonathanpeppers commented 3 years ago

@Redth @Eilon is there a switch to disable this check? I think it causes failures in CI scenarios:

https://dev.azure.com/dnceng/public/_build/results?buildId=1239230&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=ac0b0b0f-051f-52f7-8fb3-a7e384b0dde9&l=188

For now, I think I can ignore the exit code or something.

Redth commented 3 years ago

@jonathanpeppers ‘—skip edgewebview2’

jonathanpeppers commented 3 years ago

Yeah --skip edgewebview2 works: https://github.com/dotnet/maui-samples/pull/183