search

ReedCopsey / Gjallarhorn.Bindable

Unidirectional binding library built on top of Gjallarhorn for WPF and Xamarin Forms
MIT License
27 stars 10 forks source link

Opening modeless (= non modal) dialogs/windows #18

Open giuliohome opened 6 years ago

giuliohome commented 6 years ago

Hello! First of all, congrats, this is a nice project, quite complex for me (I'm used to MVVM but not to Elmish approach). I'm mentioning a sample of Gjallarhorn.Bindable after a long trail in a closed Elmish.WPF issue. The only reason why I am disturbing you is that users would obviously prefer to have the possibility to open two items at the same time so that they could possibly compare them. Anyway from a technical standpoint I am looking at the Nav.fs under the project Gjallarhorn.Bindable.Wpf and specifically at the code lines

        | ModalDialog window ->
            window.Owner <- mainWindow
            window.ShowDialog() |> ignore

I've done a very quick, dirty and rough change by replacing ShowDialog with Show and it looks like it would work as expected so maybe you might want to add an enhancement to open new modeless windows? I'd be very happy, but thanks anyway!

ReedCopsey commented 6 years ago

Yes, that works fine. The Collections sample shows multiple modeless windows already, BTW.

ReedCopsey commented 6 years ago

Login to main window switches modeless windows...

On Sun, Sep 9, 2018, 11:12 AM giuliohome notifications@github.com wrote:

@ReedCopsey https://github.com/ReedCopsey Sorry, I'm lost: where does it already show multiple non-modal windows? I tried the edit button and it opens a modal dialog... what am I missing? Thank you!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ReedCopsey/Gjallarhorn.Bindable/issues/18#issuecomment-419722564, or mute the thread https://github.com/notifications/unsubscribe-auth/AFCUms-dVF71cuztw-10-hH4dWDH8cGHks5uZS_egaJpZM4WgSvN .