Professional feedback - Githubissues

Marcusandreas commented 10 years ago

Got feedback from work!

Here are some comments of your code in webshop, which I did over the weekend. Overall the quality of code was pretty good and very easy readable :)

Webshop comments:

gotta catch em all exceptions - using different throws but catching all: RuntimeException, InvalidArgumentException
too much repeating parts of code - ex. server variable $_SERVER['DOCUMENT_ROOT']
sql injection not secure when adding new user
session key is not always unique
session key is not indexed in DB = slower performance
core/dummy.php should not be in the repository
misuse of registerError function for non-error messages reporting e.g. (registerError("Your new password has been saved", "success");)
hardcoded email message in function with HTML but not linking the URL with - usability

Marcusandreas commented 10 years ago

Needs to be split into different issues

Marcusandreas commented 10 years ago

splitted into different issues

Reedyn / Just-Another-Webshop