Reedyn / Saga

A Ghost theme designed for photostories :sunrise_over_mountains:
MIT License
282 stars 90 forks source link

Menu-system #37

Closed Reedyn closed 4 years ago

Reedyn commented 9 years ago

As this will be supported in the future by Ghost I thought it'd only be good to start to think on how to implement this.

I'm not looking into integrating anything complex, ideally it wouldn't even be nested.

I'm interested to know how others feel about this and how you would like to get menus integrated. @seanichol @PxlBuzzard

Reedyn commented 9 years ago

Currently keeping an eye on what is going on with the development on the navigation for Ghost (TryGhost/Ghost#4535) before settling on what to do with this.

seanichol commented 9 years ago

Personally speaking, I'l never use a menu beyond linking my top tag/category pages and an "About" page. So, maybe three to four links in the header... not a big fan of these "mega-menus" you see everywhere.

Reedyn commented 9 years ago

Yeah, with that I agree wholeheartedly :)

My choices right now are between the following

1. Icon based menu

Have the same design as the current menu has. The user will have to find the corresponding icon they want to display, copy the character and then paste that into the display-name of the menu item (in the settings). The theme then displays that character using the icon-font.

That would gives the same style as we have right now, and it would be easier than we have right now, but it would give some drawbacks for some people.

2. Name based menu

New design for menu, not sure how this would look but would figure out something.

Not an icon based but uses a normal font. This has the advantage that new users can easily swap between themes without adapting their menu.

3. Partial based menu

As it is right now, this is something I'd like to avoid, especially since option 1 is easier :)

shadowframe commented 9 years ago

icon based menu plz. :)

ghost commented 9 years ago

@Reedyn - You mention... "Have the same design as the current menu has." Menu? Is there already a menu of sorts?

Anyhow - my preference (for what it's worth) is that the menu should be stupid simple.
Agree, by default the menu should be expanded for mobile.
Icons and text - It's easy for icon meaning to get lost in translation, or the icon could just be rubbish. Having some text as well would keep things clear.

Reedyn commented 9 years ago

@Bizzi-Body What I'm referring to is the icon-style menu at the top right. It can be accessed and changed via the partials/links.hbs-file.

What I'm planning to do is atleast allow the option of changing the menu via the now build in system. Not sure exactly as to how to do that yet as it can be a pain to handle the icons.

ghost commented 9 years ago

Ah. Got-yah. I suppose the problem is that there are only two fields in the menu feature - title and link.

How about if people just insert any html into the menu?

i.e.
Title = Contact Us Link = /contactus/

As a MFP it would get you up and running quickly and give you time to see how the feature is used before stressing about putting effort into something that might not be required.

Reedyn commented 9 years ago

The issue is that I don't have control over how the menu system is used. And I want the theme to work out of the box with ease.

Saga with Ghosts implementation of their menu system should be able to handle many menu-items with both long and short names. That would mean going away from the very minimalist icon-based system that it currently has.