Reedyuk / blue-falcon

A Bluetooth kotlin multiplatform "Cross-Platform" library for iOS and Android
https://bluefalcon.dev
Apache License 2.0
321 stars 43 forks source link

uuid as parameter for scanning #129

Closed vishwaprojects closed 2 months ago

vishwaprojects commented 2 months ago

some times we need to scan it dynamically every time its not possible to intiate new bluefalcon instance

Reedyuk commented 2 months ago

This wont get merged until you support all of the other platforms with your change. Some are simple copy of the implementation, others are basic changes. for example macos implementation you can copy. Also you should be able to support filtering both service uuid and the optional one you pass in Please think about the many other people who use this lib and their platforms

Reedyuk commented 2 months ago

What does the comment mann mean? Please make more descriptive commit messages. I need to change your pull request, before it is merged in. Why doesn't your maven local not work?

Reedyuk commented 2 months ago

Adding maven local as a repository, means the library will pull dependencies from maven local, you must do this change in your project, then you should be able to use it

vishwaprojects commented 2 months ago

idk i followed through online resourses on web end up getting gradle errors trying since yesterday night ,please do merge asap ,about commit message just kept randomly will keep descriptive commit message let me know do u want any changes from my side

Reedyuk commented 2 months ago

This change will break the library for many others, it will not be merged until it is fully working. Please think about other consumers of the library above yourself. Look at the example projects, these demonstrate how to use maven local.

Reedyuk commented 2 months ago

Let me understand your requirements, so you want to scan for different UUID's dynamically instead of on instantiation of blue falcon.

vishwaprojects commented 2 months ago

@Reedyuk yes instead of in bluefalcon instance i need it dynamicallly

Reedyuk commented 2 months ago

going to close this in favour of the other pr