search

Reedyuk / blue-falcon

A Bluetooth kotlin multiplatform "Cross-Platform" library for iOS and Android
https://bluefalcon.dev
Apache License 2.0
328 stars 43 forks source link

Non-null service UUID constructor parameter removes all scan results for iOS #73

Closed jamesjmtaylor closed 3 years ago

jamesjmtaylor commented 3 years ago

Describe the bug Non-null service UUID constructor parameter removes all scan results for iOS, even those that match.

To Reproduce Steps to reproduce the behavior:

  1. Update the AppDelegate method in the iOS project to pass a service UUID string in the initialization of the BlueFalcon singleton.

Expected behavior Only devices that match that service should be shown.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context I recommend the following fix to iosMain/.../BlueFalcon.kt (I would create a branch and open a PR, but I don't have sufficient rights to do so): Screen Shot 2021-06-05 at 6 12 54 PM

Reedyuk commented 3 years ago

"Use the forks" or something on those lines. @jamesjmtaylor - this is exactly what forks were invented, fork this repository, create your changes and when you create a PR you can target the master to being reedyuk/blue-falcon/master.

Good luck!

jamesjmtaylor commented 3 years ago

@Reedyuk PR is up! https://github.com/Reedyuk/blue-falcon/pull/74