ReeemProject / reeem_db

Code of the reeem_db
GNU Affero General Public License v3.0
6 stars 4 forks source link

Database Adapter - ESME #40

Open Ludee opened 5 years ago

Ludee commented 5 years ago

modeller: @StevePye

Ludee commented 5 years ago

Received first version of ESME data. It has been copied to SP. First feedback: Please follow the naming convention. A look at the data already shows a good structure. We will need to optimise it a little bit. I will create an commented example that we can discuss.

Ludee commented 5 years ago

@StevePye PLease give me a smile

4lm commented 5 years ago

Hi @StevePye,

right now I'm checking the metadata for all models. Right now there is very little metadata for ESME: https://github.com/ReeemProject/reeem_db/blob/master/database_setup/reeem_db_setup_esme.sql

Input data:

 '{"title": "REEEM ESME Input",
    "description": "",
    "language": [ "eng" ],
    "spatial": 
        {"location": "none",
        "extent": "none",
        "resolution": "none"},
    "temporal": 
        {"reference_date": "none",
        "start": "none",
        "end": "none",
        "resolution": "none"},
    "sources": [
        {"name": "none", "description": "none", "url": "none", "license": "none", "copyright": "none"} ],
    "license":
        {"id": "tba",
        "name": "tba",
        "version": "tba",
        "url": "tba",
        "instruction": "tba",
        "copyright": "tba"},

Output data:

    '{"title": "REEEM ESME Output",
    "description": "Health externalities (unit cost factors) due to air pollution",
    "language": [ "eng" ],
    "spatial": 
        {"location": "none",
        "extent": "",
        "resolution": ""},
    "temporal": 
        {"reference_date": "",
        "start": "2020",
        "end": "2050",
        "resolution": "10 years"},
    "sources": [
        {"name": "ESME Model", "description": "tba", "url": "https://openenergy-platform.org/factsheets/models/144/", "license": "none", "copyright": "Energy Technologies Institute (ETI), UCL"} ],
    "license":
        {"id": "tba",
        "name": "tba",
        "version": "tba",
        "url": "tba",
        "instruction": "tba",
        "copyright": "tba"},

Can you provide me with missing data? If you don't know how to commit here on GitHub, then just take above metadata strings, fill in the missing values (use "none" as value if you there is no value) and post both strings (here in the comment section), I will take it then from there ...

4lm commented 5 years ago

This commit belongs in this issue https://github.com/ReeemProject/reeem_db/commit/fd774d5285f6243b512601ad7e7cf770aa9b78ec

4lm commented 5 years ago

@StevePye, a little reminder for: https://github.com/ReeemProject/reeem_db/issues/40#issuecomment-496995157

CC: @Ludee

PS: Most important is sources (for input and output data) and under which licenses you distribute your output data

4lm commented 5 years ago

@StevePye, thanks again for the metadata via email. As communicated via email, we still need the license info for the output data! Please post the license info directly in this ESME issue thread.

Thanks in advance!