search

Reeywhaar / want-my-rss

RSS features for Firefox
Other
113 stars 10 forks source link

Icon for dark theme #1

Closed Reeywhaar closed 2 years ago

happysurf commented 5 years ago

Yes, with my FirefoxColor dark theme is bad to see the icon, I suggest orange color.

rss

Reeywhaar commented 5 years ago

https://github.com/Mte90/Share-Backported/issues/15 https://stackoverflow.com/questions/48540523/firefox-pick-page-action-icon-for-dark-light-themes https://discourse.mozilla.org/t/use-theme-colors-for-svg-favicons/29165/7

It really irritates that Mozilla doesn't provide any suitable way to select icon for theme, seems like API is very inconsistent in this part. They have a way for their own extensions, even have Photon page dedicated to this, yet provide no way to actually set color.

The solutions for now is either use neutral (#999, which looks like bug in both themes, or orange as you suggested which distracts) color, or have an option to manually set icon color, which is over-complication for such simple thing.

Reeywhaar commented 2 years ago

I've recently updated icon, and now I hope it has better appearance. image