search

RefactoringTools / HaRe

The Haskell Refactoring Tool
http://www.cs.kent.ac.uk/projects/refactor-fp/
Other
139 stars 32 forks source link

Remove overlapping instance on ghc-8.0.2 #43

Closed expipiplus1 closed 7 years ago

expipiplus1 commented 7 years ago

Uses the MIN_VERSION_GLASGOW_HASKELL macro introduced in ghc 7.10.2 http://downloads.haskell.org/~ghc/master/users-guide//phases.html#standard-cpp-macros

HaRe now compiles under ghc 8.0.2

expipiplus1 commented 7 years ago

It might be worth adding a 8.0.2 check on travis. I don't know how easy that'll be before it's properly released though.

alanz commented 7 years ago

I am pretty sure it is available via the hvr ppa, will take a look

RyanGlScott commented 7 years ago

NB: If you really want this instance on GHC 8.0.2 or later, all you need to do is add an {-# OVERLAPPING #-} pragma to the instance. See https://ghc.haskell.org/trac/ghc/ticket/12881 for details.

This appears to be worked around in HEAD, so I'll leave it up to you if you want to do this.