search

RefactoringTools / HaRe

The Haskell Refactoring Tool
http://www.cs.kent.ac.uk/projects/refactor-fp/
Other
139 stars 32 forks source link

Allow HaRe to compile with ghc 8.0.2 rc1 #49

Closed expipiplus1 closed 7 years ago

alanz commented 7 years ago

Will this work for rc2? I am using 

#if defined(MIN_VERSION_GLASGOW_HASKELL) && (MIN_VERSION_GLASGOW_HASKELL(8,0,1,1))

in ghc-exactprint, but we need the opposite sense of it. Perhaps negate the whole thing?

alanz commented 7 years ago

@expipiplus1 do you have a configuration that can build all the dependencies? I am battling to build ghc-mod at present.

expipiplus1 commented 7 years ago

This change is the same as the way I fixed things in ghc-mod https://github.com/DanielG/ghc-mod/blob/b859ca7f40c1a6b0a4250497dca1f1c524e08f14/Language/Haskell/GhcMod/Gap.hs#L108

I'll get you a build environment for ghc-mod soon.

alanz commented 7 years ago

ghc-mod master branch works fine now, it just needed a bump on directory

expipiplus1 commented 7 years ago

great, glad you got it working :)

alanz commented 7 years ago

This is superseded by https://github.com/RefactoringTools/HaRe/pull/51

expipiplus1 commented 7 years ago

Super, glad it's working :)