Closed RedRafe closed 5 months ago
Hi, thanks a lot for reviewing with such short notice. I'm still trying to add some features of the bullet list before tomorrow (so wait a sec before merging :-) ). Just to answer your points:
nicefill code was taken from nicefill mod, I dont have time to refactor it for us so i'll be ditching the module and just add the mod to the event modlist. but I'll be happy to implement one for us in the future
I do not have the images unfortunately, only the code
will add scenarios to templates & turn off debug mode obviously (and also add poll/restart module to them too I guess)
script.on_event
I really don't like to add to luacheck cuz I also think it was left out to catch script.
instead of using the event. I'm going to disable the check in that line instead of adding to luacheck, and implement the customInput support later
I was getting crashes before adding any gui, don't know it it was a mod or something related to the toast module...
@grilledham I believe this to be the "final" version before the event. Got a couple features in from the bullet list too. I would have loved to add Diggy's cave collapses to the underworld surface, but need to rework the Diggy's module to work outside surface 'redmew' and check other Diggy's template data... I'll have a look tomorrow if I can
Other than that, maybe just have a look at ../scenario/restart_command.lua
(which is the main addition that uses shared_globals.lua
and rocket_launched.lua
to set the target condition & pass it along) if you want
LGTM. Would you like me to merge now?
Sure
This would be the 1st draft of the April Fools scenario.
As of current time of posting this. I'm running out of time before 2024 April Fools', so I expect this PR to be a draft/test of the features rather than a finished product. Some tips to navigate the new code:
Relevant global redmew changes
resources/alien_biomes
: handles compatibility if Ab is enabled (needs to be imported in scenarios to work)map_gen/shared/alien_biomes
: generates surfaces MapGenSettings on request (usingresources/alien_biomes
)luackeckr
: added couples fields.script.on_event
was missing (maybe on purpose? seems quite relevant) but I had to add it because ourevent
module does NOT handleCustomInput
events (crashes on init), which are instead supported with standardcore/event_handler
so I'll probably update our Event module when I'll have time / if it'll be neededutils/gui_test
: crashed in some occasions, IDK the exact reason, will need to investigate laterMain dir:
map_gen/maps/april_fools
is the new subfolder, structured as: ---scenario
: relevant features that may or may not be included in the map ---modules
: only "random/crazy" modules (each module is a 1-N level of some crazy behaviour, controlled by the scenario) ---2019.lua
and2024.lua
: the two version of the scenario (reconstructed fromPinguin
of 2019 and expanded)There's a good degree of copy/paste to quickly adapt some of our modules to work outside RedmewSurface, I'll tidy 'em up if needed afterwards. Half of the scenario is at RedMew Data/april-fools (for the data stage part and some minor tweaks)
How to test
/af-debug
,/af-reset
,/af-max
, & the 3 shortcuts in your quickbar:teleport up
,Teleport down
,Parallel camera
I'm attaching below a copy of my mod-setting.dat, v0.2.4 of the RedMew mod, & a copy of a save
Short-term feature until event launches
Add a RPG system to increase mininig speed and combat stats for players (RedMew)using DoingThingsByHand modisland
ormines
or both (RedMew)Add/Fix/Refactorusing NiceFill modscenario/nice-fill.lua
feature (RedMew)mod-settings.dat.zip redmew-data_0.2.4.zip af_test-deflated.zip
(yup, fails build because of
nice-fill.lua
I know)