Briefly speaking, there are some problems, recently appeared after Release 3.12. Functions GELQS/GEQRS were made DEPRECATED and have been replaced by GELS in tests of QR/LQ factorizations. But,
GELS calls specific factorization depending on input size: QR for m >= n and LQ for m < n. Test does not take into account this knowledge and wrong factorization can be called for specific parameters m and n.
Even if parameters, passed to GELS are correct, test can be also failed for matrices near overflow/underflow. I believe, that it happens, since GELS calls scaling routines inside, but previous version GELQS/GEQRS does not. Behavior is also changed in that way.
It is important to point out, that test is failed on the next iteration of parameter K while data is improperly changed on the first iteration. That's why fails are reproduced only on fixed input file.
Thinking of solution, I suggest to call the correct factorization on each iteration of inner loop for parameter K. It will solve any problems, related to occasionally changed data inside the test. Maybe this solution is not fully optimal, since it does not restrict any inputs into GELS, but it can be discussed.
[x] If the PR solves a specific issue, it is set to be closed on merge.
Fix fails of tests for QR/LQ factorizations
Hello! This PR is willing to close issue #973.
Briefly speaking, there are some problems, recently appeared after Release 3.12. Functions
GELQS/GEQRSwere made DEPRECATED and have been replaced byGELSin tests of QR/LQ factorizations. But,GELScalls specific factorization depending on input size:QRform >= nandLQform < n. Test does not take into account this knowledge and wrong factorization can be called for specific parametersmandn.GELSare correct, test can be also failed for matrices near overflow/underflow. I believe, that it happens, sinceGELScalls scaling routines inside, but previous versionGELQS/GEQRSdoes not. Behavior is also changed in that way.It is important to point out, that test is failed on the next iteration of parameter
Kwhile data is improperly changed on the first iteration. That's why fails are reproduced only on fixed input file.Thinking of solution, I suggest to call the correct factorization on each iteration of inner loop for parameter
K. It will solve any problems, related to occasionally changed data inside the test. Maybe this solution is not fully optimal, since it does not restrict any inputs intoGELS, but it can be discussed.