Closed ACSimon33 closed 1 month ago
@martin-frbg If this is accepted, we probably could take a look at https://github.com/OpenMathLib/OpenBLAS/issues/4128 again
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 0.00%. Comparing base (
690067c
) to head (4f504e0
). Report is 20 commits behind head on master.:exclamation: Current head 4f504e0 differs from pull request most recent head 51219d2
Please upload reports for the commit 51219d2 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
There were several issues flagged by GCC when using LTO. The things I fixed are the following:
cblas_f77.h
header contained some wrong declarations, where complex arguments had types likefloat*
ordouble*
instead ofvoid*
LAPACK_lsame
declaration had 4 STRLEN arguments instead of the necessary 2I compiled with
-Werror=lto-type-mismatch
and it seems all issues are resolved.We could enable LTO in the CI pipelines (CMake:
-DCMAKE_INTERPROCEDURAL_OPTIMIZATION=ON
) and add the-Werror=lto-type-mismatch
flag as well now.Fixes #334 Fixes #990
Checklist