Reference-LAPACK / lapack

LAPACK development repository
Other
1.51k stars 441 forks source link

Apply fixes from #540 to LAPACKE_?tprfb_work #734

Open weslleyspereira opened 2 years ago

weslleyspereira commented 2 years ago

Thanks @angsch!

The fix likely applies toLAPACKE_?tprfb_work, too. The dimensions of A depend on side. When side = 'Left', A has minimum dimensions (K, N). When side = 'Right', A is (M, K). The row major interface seems to only support side = 'Left': https://github.com/Reference-LAPACK/lapack/blob/28f7e8309608b92aaec2e2556d4b25d758ccada9/LAPACKE/src/lapacke_ctprfb_work.c#L52-L53

There may be other routines too. More tests are needed if we want to find those issues with row-major matrices in LAPACKE.

langou commented 2 years ago

More tests are needed if we want to find those issues with row-major matrices in LAPACKE.

Maybe \<T>LAPACK can help testing row-major format for LAPACKE since it is easy to work with many data layout within the \<T>LAPACK framework.