search

Reference-LAPACK / lapack

LAPACK development repository
Other
1.49k stars 436 forks source link

BDSQR workspace does not take into account fallback into LASQ1 #996

Closed dklyuchinskiy closed 3 months ago

dklyuchinskiy commented 6 months ago

BDSQR workspace does not take into account fallback into LASDQ1

After PR https://github.com/Reference-LAPACK/lapack/pull/234 and PR https://github.com/Reference-LAPACK/lapack/pull/989 workspace of BDSQR has been changed from 4 * N to 4 * (N - 1).

But this new value is not enough to run LASDQ1 in case when no singular values is desired. LASQ1 and, consequently, LASQ2 strongly requires 4 * N memory.

image

I have already caught segmentation fault in this case. Documentation should be fixed one more time to take into account ( .NOT. ROTATE ) branch.

dklyuchinskiy commented 3 months ago

Fixed