search

ReflectionsProjections / rp-api-2023

Core Backend API Layer for Reflections | Projections 2023, powered by Nest.js
MIT License
0 stars 0 forks source link

Create S3 endpoint for resume uploads #21

Closed kajalpatelinfo closed 1 year ago

kajalpatelinfo commented 1 year ago

This PR creates an endpoint for S3 uploads (for resumes in particular) on the current registration form. It also adds a README so that users may properly configure their environment variables for AWS to pull.

@xuxey @rohannunu @anandani4136 @shreyad216 Please review when you have a chance!

kajalpatelinfo commented 1 year ago

Overall looks solid, might want to remove some of the unnecessary console logs once debugging is complete, and add a few more comments for classes like S3ModuleService for documentation.

Good catch on the debugs! Removed. Will add documentation soon.

xuxey commented 1 year ago

@kajalpatelinfo Should I hold off on my review until the Signed URI funcitonality we discussed is also ready to ship?

kajalpatelinfo commented 1 year ago

Closing this PR in favor of #24.