Closed anandani4136 closed 1 year ago
Good to see this functionality in review! @anandani4136
Some broad improvements we can make:
AuthModule
and into its own WalletModule
& controller, since they have little to do with auth. .env
section of the project readme@xuxey @kajalpatelinfo @rohannunu
Barring the QR code's value being set to the hashed token (which will be completed imminently), please review this and let me know what can be improved on and any feedback. Thanks!
❌ An unexpected error occurred. For more details, check console
Error: The process '/opt/hostedtoolcache/node/16.20.1/x64/bin/npx' failed with exit code 1
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 43.79% (-26.26% 🔻) |
229/523 |
🔴 | Branches | 6.82% (-0.68% 🔻) |
3/44 |
🔴 | Functions | 23.19% (-6.32% 🔻) |
16/69 |
🔴 | Lines | 41.85% (-25.22% 🔻) |
195/466 |
Report generated by 🧪jest coverage report action from d9cadd248152caff45f3f6bff4ee93fca979958a
This endpoint adds a few points of functionality, such as • Google Wallet class generation for the R|P pass • User-specific pass generation, linked by email • Other ease-of-life helper functions
This takes in the email of the user and, after looking up the name of the user linked to the email, creates a custom R|P Google Wallet Event Pass for Reflections|Projections
Remaining tasks: Link QR-hash function result with the QR value