ReflectionsProjections / rp-api-2023

Core Backend API Layer for Reflections | Projections 2023, powered by Nest.js
MIT License
0 stars 0 forks source link

S3 bucket changes #30

Closed kajalpatelinfo closed 1 year ago

kajalpatelinfo commented 1 year ago

This PR adds the server-side functionality for S3 uploads. Specifically, it uses the cookie containing information about the user to guide the key of the upload. It directly uploads as opposed to using a presigned URL.

@rohannunu @anandani4136 @xuxey @rachelh6 Please review when you have the chance!

github-actions[bot] commented 1 year ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
66.89% (-1.74% πŸ”»)
404/604
πŸ”΄ Branches
16.95% (+0.62% πŸ”Ό)
10/59
πŸ”΄ Functions
29.27% (-0.31% πŸ”»)
24/82
🟑 Lines
64.31% (-1.26% πŸ”»)
346/538
Show new covered files 🐣
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :--------------- | :--------- | :------- | :-------- | :----- | | 🟒 | s3/s3.module.ts | 100% | 100% | 100% | 100% | | πŸ”΄ | s3/s3.service.ts | 35% | 0% | 33.33% | 27.78% |
Show files with reduced coverage πŸ”»
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :------------------------------------------------------------------------------------- | :-------------------------------------------------------------- | :-------------------------------------------------------------- | :---------------------------------------------------------- | :----------------------------------------------------------- | | πŸ”΄ |
`...` / attendees.controller.ts
|
59.62% (-13.36% πŸ”»)
|
55.56% (-27.78% πŸ”»)
|
22.22% (-2.78% πŸ”»)
|
58% (-13.43% πŸ”»)
| | 🟒 |
`...` / create-attendee.dto.ts
|
82.14% (-17.86% πŸ”»)
|
0% (-100% πŸ”»)
|
0% (-100% πŸ”»)
| 100% |

Test suite run success

17 tests passing in 13 suites.

Report generated by πŸ§ͺjest coverage report action from 1073326335dba25e98560b21c42ebdb75d62bd01