ReflextionsDev / Zombiehood

Project Adder is an open-sourced 2D zombie shooting sandbox game, blending run & gun mechanics with rogue-lite elements. Open Sourced under GNU GPL V3.
https://store.steampowered.com/app/2598410/Project_Adder/
Other
9 stars 2 forks source link

Fixes player falling of the edge on level end #128

Closed Everade closed 4 days ago

Everade commented 2 weeks ago

Fixes https://github.com/ReflextionsDev/Zombiehood/issues/59

Todo:

Everade commented 2 weeks ago

@ReflextionsDev Upon inspecting the end-transition, i noticed that a 1s invincibility timer is already added during the transition. The transition itself also takes 1 second, so fairly short. The transition only starts once the player is beyond visibility. Meaning that, even if we take over player control, you won't really notice it either way unless the player decides to walk back during that 1 second.

Additionaly, considering the player is already invulnerable, i don't see any issues with zombies walking past the map.

I would say we merge this fix, and if you're still interested into adding the other todos that you've mentioned here https://github.com/ReflextionsDev/Zombiehood/issues/59#issuecomment-2308611345 Then we can open a new issues for them.

However I don't see any priority in them since they don't really change much.

ReflextionsDev commented 4 days ago

Perfect, ty @Everade !