search

Reform-to / reform.to

Website
1 stars 0 forks source link

searching by zip should work even without latitude, longitude in url #26

Open ghost opened 10 years ago

ghost commented 10 years ago

Currently I must share my geographic coordinates to send a url to someone else or for testing, something like below where LAT and LONG are coordinates for my location:

http://reform.to/#/home/LAT,LONG,postal_code,60201

I want to be able to send:

http://reform.to/#/home/,,postal_code,60201

OR

http://reform.to/#/home/postal_code,60201

christopheradams commented 10 years ago

That's not exactly right. The first time you visit the site, if you agree to share your location, the URL will update with your coordinates, like:

http://reform.to/#/home/lat,lng

where the coords are for your current location.

Then, if you perform a search, the URL bar will update to:

http://reform.to/#/home/lat,lng,resolution,query

Where the coords are for your search location, i.e. what you get if you put query into google maps.

However, the exact coordinates aren't important, only the district and state. It might be better that the URL only ever updates to show state, district (if there is one) and your query string. It would take some refactoring and change in information flow and detail.

ghost commented 10 years ago

Oh ok, make sense. Can close

On Thu, Aug 7, 2014 at 3:53 PM, Christopher Adams notifications@github.com wrote:

That's not exactly right. The first time you visit the site, if you agree to share your location, the URL will update with your coordinates, like:

http://reform.to/#/home/lat,lng

where the coords are for your current location.

Then, if you perform a search, the URL bar will update with the to:

http://reform.to/#/home/lat,lng,resolution,query

Where the coords are for your search location, i.e. what you get if you put query into google maps.

However, the exact coordinates aren't important, only the district and state. It might be better that the URL only ever updates to show state, district (if there is one) and your query string. It would take some refactoring and change in information flow and detail.

— Reply to this email directly or view it on GitHub https://github.com/Reform-to/reform.to/issues/26#issuecomment-51441568.