search

Reform-to / reform.to

Website
1 stars 0 forks source link

Race condition from auto-geolocated search results should be dealt with #28

Open christopheradams opened 10 years ago

christopheradams commented 10 years ago

I noticed a race condition in the geolocation code. Sometimes the geolocated search results replace results of subsequent searches, or show up when there should be no results. I'm still looking into this. For the time I disabled the code that kicks off geo-location. I think it might work better if we change the interface to show a "Search your location" link that can be clicked, rather than auto-populating the search results as we have been doing (which is slow anyway).

ghost commented 10 years ago

Agree On Aug 13, 2014 9:08 AM, "Christopher Adams" notifications@github.com wrote:

I noticed a race condition in the geolocation code. Sometimes the geolocated search results replace results of subsequent searches, or show up when there should be no results. I'm still looking into this. For the time I disabled the code that kicks off geo-location. I think it might work better if we change the interface to show a "Search your location" link that can be clicked, rather than auto-populating the search results as we have been doing (which is slow anyway).

— Reply to this email directly or view it on GitHub https://github.com/Reform-to/reform.to/issues/28.

ghost commented 10 years ago

Thinking about again. Do we want to make interface more busy or keep minimal? I think better to disable and work out a fix rather than put our problem onto user in form of an interface choice Also opens the Pandora box on adding more interface addons. On Aug 13, 2014 9:11 AM, "Jon Phillips" jon@fabricatorz.com wrote:

Agree On Aug 13, 2014 9:08 AM, "Christopher Adams" notifications@github.com wrote:

I noticed a race condition in the geolocation code. Sometimes the geolocated search results replace results of subsequent searches, or show up when there should be no results. I'm still looking into this. For the time I disabled the code that kicks off geo-location. I think it might work better if we change the interface to show a "Search your location" link that can be clicked, rather than auto-populating the search results as we have been doing (which is slow anyway).

— Reply to this email directly or view it on GitHub https://github.com/Reform-to/reform.to/issues/28.