Refty / mongo-thingy

:leaves: Powerful schema-less ODM for MongoDB and Python (sync + async)
https://mongo-thingy.readthedocs.io
MIT License
68 stars 12 forks source link

Rename client to avoid conflicts with eponym model attributes #7

Closed trubesv closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling e1c75407a19ce318017c803cc33358b196ce8551 on trubesv:master into dca750ccbf28505d8364ba7992fe5db10e790718 on numberly:master.

ramnes commented 6 years ago

We still want the Thingy class API (I'm not talking about instances) to have a client attribute. You can do so with a client classproperty. It shouldn't conflict at the instance level.

ramnes commented 6 years ago

Also, we want a test case to check that conflicts don't happen anymore at the instance level, for future backward compatibility purposes.

ramnes commented 6 years ago

This is fixed in Thingy 0.8.0. Please update it here. :+1: