RefugeRestrooms / refugerestrooms

REFUGE restrooms indexes and maps safe restroom locations for trans, intersex, and gender nonconforming individuals.
http://www.refugerestrooms.org
GNU Affero General Public License v3.0
891 stars 263 forks source link

icky bits with geolocation + database structure potential ideas #162

Open emfetz opened 10 years ago

emfetz commented 10 years ago

Hi! :)

In an attempt to further the conversation about database structure (and application functionality), here are some issues I am having:

I have almost completely cataloged all the lockable (mostly single-seat) restrooms for my college campus, but since street addresses are either nonexistent or very hard to find for academic buildings --landlocked as they are by parking lots and sidewalk-jungles-- I have found it much easier to find gps coordinates for the buildings (using either google maps or openstreetmap.org to pinpoint, especially since my phone's gps rarely works when restroom-scouting inside of buildings). So, I am sitting on an awful lot of un-posted data for my campus' restrooms because I am unable to find/infer many (if any) accurate postal addresses.

In addition to not being able to find street addresses for buildings, I also discovered that google maps is not able to accurately pinpoint a building I actually have a verified street address for. See redacted image of an already-submitted restroom below: map for submitted restroom

What I would really like to see, though, is a way to input actual gps coordinates instead of trying to rely solely on street addresses, which can be very faulty.

Along the same lines of database structure/interaction, here is a list of super-nit-picky criteria I have come up with from my wanderings so far which maybe might be helpful? anyways, here goes: restroom label [labeled handicap accessible?], is it lockable? [does the lock look safe?], directions [able-bodied version, handicap version if applicable (side note: idk if 'handicap' is ok terminology ?), integrated version], facilities [num seats {num handicap seats}, num urinals, num sinks, etc.], street address, long/lat, if restroom is handicap accessible [is building handicap accessible?, lat/long of handicap entrance, etc.], hours building is open [day M/T/W/R/F/Sat/Sun {time block(s)}, is schedule approx or exact?, what parts of year does this schedule apply? {link to applicable calendar}], general tips/comments, images [~ of bathroom, ~ of entrance {~ to building, ~ to restroom}, images potentially annotated???], etc.

Sorry if this is too much/general! Thank you all so much for your hard work on this project! :)

tkwidmer commented 10 years ago

The issue with gps locations for college campuses is a problem. I've had some discussion about this with some users of the site and allowing direct GPS entry might be the best solution to this. I kept the lat/long display off of the form because i feared that folks might worry that since they didn't know that info they wouldn't be able to submit a bathroom (which isn't true since we do the geolocation on submit). Maybe there is a way to add it as an optional area to the form that can be expanded for more detail.

One of the struggles in this I see is there is a lot of kinds of data we could keep, but I do fear that for some folks having a big long intimidating form and needing to input all that information might be really discouraging and keep people from entering locations (especailly if they have a few to enter, such as yourself.) So it will be an important discussion to have re: walking and finding the balance between the two. ( not getting enough data, vs asking for too much).

I know somebody was working on a system to suggest edits for bathrooms, which could be approved by admins. And perhaps that is a place for this, that users can edit the bathroom and contribute even more data about each one.

I do want to keep the barrier to entry as low as possible (thats why we do not want to get users to sign up and provide an email and password). Thats my one fear with asking for a lot more data of our users. But otherwise I agree, more data is always better.

leavens9 commented 10 years ago

I would use the same model Uber does in their app.

1- user clicks add a restroom 2- along with the form they are shown a map with a pin in the GPS location/manual location they entered. 3- They can press edit, and move the pin to fine tune the location

That way, they are technically inputting a custom GPS coordinate, but with the ease of just moving a pin.

Also, this gives users the ability to edit a current restroom and fine tune the location if it's slightly off.

tkwidmer commented 10 years ago

Sure. that could be done, we could move the geocoding on input to be done on the client-side, render that point on a map and let it be movable. I'm def ok with that change. --

We dont have the functionality to have users edit yet -- id prefer to have a double check in place before we just save that info to the db -- Ie. it has to be approved by an admin just to check that its not being changed to ludicrous data that doesn't make sense.

Part of the fear surrounding adding the ability to edit is we might have some folks (read: violent TERFS, or other trans-exclusionary folk) attack the site and zero out or completely screw up good listings. To counteract that we have been thinking about a way for Users to "suggest" edits. That would need to be approved by an admin.

emfetz commented 10 years ago

It seems to me that a wiki-like storage/edit system would solve the potential problem of potentially destroying good data since all edits are kept. If storage limitations are an issue, admins could delete unneeded/spam versions of entries. Just a thought.

tkwidmer commented 10 years ago

If somebody has the time to build that functionality that would be great, but thats not a functionality that currently exists. There is just the restroom listing on the restroom table, which is created upon submit, and shown when requested.

kiesia commented 10 years ago

Bathroom versioning will exist any day now. :smile: I will have a lot more time after this week, and finally building in versioning is really high on my schedue.

tkwidmer commented 10 years ago

yesssssss @kiesia ! <3 <3 <3

johana-star commented 10 years ago

@kiesia This may be bikeshedding on my part, but how are you looking at versioning restrooms? Here's a good list… I think PaperTrail is pretty good.

tkwidmer commented 10 years ago

looks like PaperTrail is what is being used right now in the branch in @kiesia 's fork https://github.com/kiesia/refugerestrooms/blob/feature/users_can_propose_updates/Gemfile

mathonsunday commented 10 years ago

@kiesia Can you make an issue for bathroom versioning and assign it to yourself? I don't want people to have to read through a long discussion in order to know that bathroom versioning is being actively worked on.

tkwidmer commented 10 years ago

@mathonsunday there is an issue for it already https://github.com/RefugeRestrooms/refugerestrooms/issues/126

kiesia commented 10 years ago

@mathonsunday @tkwidmer I've amended the title of that issue to be clearer.