search

RefugeRestrooms / refugerestrooms

REFUGE restrooms indexes and maps safe restroom locations for trans, intersex, and gender nonconforming individuals.
http://www.refugerestrooms.org
GNU Affero General Public License v3.0
894 stars 261 forks source link

Location Services Disabled; Tell them they need to enable. #264

Closed cs09g closed 6 years ago

cs09g commented 8 years ago

os: window 7 web browser: latest chrome

when click search button with no query, refreshing animation starts with no reaction. at least it should show what do i do, and stop the animation because it does not search anything.

Hkly commented 7 years ago

What's the expected behavior when searching without a query? The pull request referencing this https://github.com/RefugeRestrooms/refugerestrooms/pull/269 seems to imply that it searches the current location if no query is entered, but when I try that I'm just left spinning.

cs09g commented 7 years ago

It does show the message that a query should be entered, but spinning icon doesn't stop. And, I don't know actually 'Search by Current location' button works. The page doesn't move to next and spinning icon is still moving. Maybe I'm at out of US?

Hkly commented 7 years ago

Ah so it looks like you have location services blocked or disabled on your browser. When location services is enabled, searching with no query should do a search on your current location. If location services is blocked, the animation just hangs and no request is being made.

A fix for this would maybe be adding a message letting users know they need to enable location services. And stop the animation spinning too :P

cs09g commented 7 years ago

@Hkly Right! I guessed so. That fix you just mentioned would be great.

DeeDeeG commented 6 years ago

I believe this is fixed by #359.