search

RefugeRestrooms / refugerestrooms

REFUGE restrooms indexes and maps safe restroom locations for trans, intersex, and gender nonconforming individuals.
http://www.refugerestrooms.org
GNU Affero General Public License v3.0
894 stars 261 forks source link

Potential UX fix to issue #264. #269

Closed CullenIO closed 7 years ago

CullenIO commented 8 years ago

Adds a message to tell the user it is searching by location.

mi-wood commented 8 years ago

Thanks for the PR!

I agree that the current placeholder seems to be lacking full context for what happens during a blank search. I'd personally be in favor of a label vs using placeholder fields. There's much more liberty to be descriptive and it's permanent. Something like "Search by location (defaults to current location)". I don't think we're constricted with screen real estate or anything

mi-wood commented 8 years ago

Also, sorry for the slow reply!

tkwidmer commented 8 years ago

Yeah i'd prefer to use a label or a placeholder, but either of those would be wonderful! Thanks for this!

mi-wood commented 7 years ago

@CullenIO Do you have plans to fix this up or should we close this for now?

mi-wood commented 7 years ago

Going to close this for now, since it's been awhile

DeeDeeG commented 7 years ago

(I notice this is closed, but this still might be something we could accept, since there are no merge conflicts last I checked.)

Alright, here's what this looks like for now (screen recording):

https://gfycat.com/FocusedMiserlyIlladopsis

Is there anything that should still be changed?

tkwidmer commented 7 years ago

I think the consensus was that we would rather this be a placeholder or a label vs changing the value of the field and putting this in as a value? @DeeDeeG

DeeDeeG commented 7 years ago

I think I get what you're saying. It shouldn't end up in the search box as something users would accidentally submit. Correct me if I'm wrong.

FWIW, I'm clicking around, and I'm finding that it's just about impossible to accidentally search for the text "Searching by current location..." (I can't select it, I even tried to copy and paste it but when I try to select it, it kind of disappears and is replaced with light grey "Enter a query". It doesn't go through even when manually typed??)

The one placeholder in that box I've managed to get as a search, by accident, was "1 Embarcadero Center, San Francisco, CA ...etc..." but I can't figure out how to do it reliably.

Edit: Is the problem that it might delete users' search terms that they had typed? I think this can't happen, because the search box has to be empty for this text to show. In fact, the dedicated "search by location" button has no explanatory text in the box, as this PR stands, only the magnifying glass button, when search box is empty. (the buttons both have tooltips when hovered, though.)