Update to Rails 5.1.4

[DeeDeeG]

Context

• Fixes #287
• Mostly just upgrades gems, also merges in the new default config files (but I commented out/disabled the changes until we research the new defaults or want to switch over).

Summary of Changes

• Note: The reason/my rationale for each change is in the commit messages.
• The rails, devise, mail_form, simple_form, activeadmin, dotenv-rails, and cucumber-rails gems have been upgraded. These were required in order to move to Rails 5.1.4 without dependency conflicts.

• The rails app:update command was run (while logged into the vagrant box), which pulls in the default config files that were added or changed since Rails 5.0. I had to accept or reject these files verbatim, so I accepted them, then reviewed my local git diff for each file, and changed things back (manually) until there were no functional changes compared to before this PR. i.e. if there was a functional change I tended to comment it out. If some of our lines were deleted, I added them back in. (This was kind of like resolving merge conflicts in git, but more by-hand.)

  • Much of the config file changes are improved comments or formatting from the upstream Rails community.

Checklist

• [x] Tested Mobile Responsiveness
• [ ] Added Unit Tests
• [x] CI Passes
• [ ] Deploys to Heroku on test Correctly (Maintainers will handle)
• [ ] Added Documentation (Service and Code when required)

Screenshots

Before

After

[DeeDeeG]

By the way, there is one "deprecation warning" for outdated code from before Rails 5.1:

DEPRECATION WARNING: ActionView::Template::Handlers::Erubis is deprecated and will be removed
from Rails 5.2. Switch to ActionView::Template::Handlers::ERB::Erubi instead.
(called from <top (required)> at /vagrant/config/application.rb:7)

The line that generates this error (line 7 in config/application.rb) is:

# Require the gems listed in Gemfile, including any gems
# you've limited to :test, :development, or :production.
Bundler.require(*Rails.groups)

So this line imports everything in our Gemfile... but we don't even specify Erubis directly in the Gemfile. It does appear in Gemfile.lock... so I assume one of our actual dependencies depends on erubis. I think, logically, we can expect this dependency to be dropped by the time Rails 5.2 comes around, or by definition, that gem will be completely unusable (because its dependency is unusable).

In other words, I think there's nothing obvious we can do about it besides hunt down whatever depends on erubis and update it, or wait for an appropriate update to come out (such an update may not exist quite yet). and I presume this problem will "fix itself" around the time Rails 5.2 has been out for a few months.

Edit: I believe the gem is better_errors 2.1.1 (depends on 'erubis') which should be updated to better_errors 2.3.3 (requires 'erubi').

[DeeDeeG]

I'm going to delete (and gitignore) some files per your comment above. I can keep iterating until it looks right.

[mi-wood]

@DeeDeeG I'm going to go ahead and merge this. Thanks!