RefugeRestrooms / refugerestrooms

REFUGE restrooms indexes and maps safe restroom locations for trans, intersex, and gender nonconforming individuals.
http://www.refugerestrooms.org
GNU Affero General Public License v3.0
894 stars 261 forks source link

Hotfix/patreon update #398

Closed KurtPrice closed 6 years ago

KurtPrice commented 6 years ago

Context

Summary of Changes

tkwidmer commented 6 years ago

I commented on the issue @KurtPrice, with a recommendation about adding a more visable button to the home page. And once you do that, i'll get this merged.

Thanks so much @KurtPrice

KurtPrice commented 6 years ago

Sounds good, I'll work on adding that. This is my first ruby project.

tkwidmer commented 6 years ago

If you merge develop, I made a change that makes the footer more readable: https://github.com/RefugeRestrooms/refugerestrooms/pull/403

tkwidmer commented 6 years ago

looks like the image itself needs to be commited into the assets/images directory

KurtPrice commented 6 years ago

Wow, I don't know how I failed to commit that. I will merge in develop and add that image for sure this time.

tkwidmer commented 6 years ago

Last comment, I promise.

can you update the code to the following

   .row.even-more-headroom
     .col-xs-6.col-sm-3.col-sm-offset-3
       = link_to image_tag("app-store.svg", role: "img"), "https://itunes.apple.com/us/app/refuge-restrooms/id968531953?mt=8"
     .col-xs-6.col-sm-3.col-sm-offset-3
        = link_to image_tag("play-store.png"), "https://play.google.com/store/apps/details?id=org.refugerestrooms"
   .row.more-headroom.splash-bottom-padding
     .col-xs-12.col-sm-6.col-sm-offset-3
      = link_to image_tag("patreon.png"), "https://patreon.com/refugerestrooms"

With this implementation the app store and play store logos will show up side by side, with the patreon link below them.

Thanks so much for your work on this!

tkwidmer commented 6 years ago

Specs are now failing, which seems unrelated. Code looks good to me.

tkwidmer commented 6 years ago

I'm restarting the build, since the Cucumber tests sometimes fail intermittently

KurtPrice commented 6 years ago

Awesome, thanks for the help, I was worried about what was causing it to fail. It looks pretty good to me!

tkwidmer commented 6 years ago

@KurtPrice no problem. I noticed the problem, and figured I could just fix the issue instead of bothering you since i had said earlier it was going to be my last comment. ^.^ Thanks for contributing!