Closed vancloss closed 6 years ago
Wow, thank you for this translation!
I can give technical feedback to make sure this works as expected. And we would also like to get another native speaker or two to review the translation, if possible.
Anyways, merci beaucoup! (I don't speak much French, but I do know that much!)
You're welcome, it's always a pleasure to help ! I can ask some friends to take a look at the translation. On the technical side, I installed the application (i just followed the instructions which are in the contributing file) and I test with the french version, it was working well. I don't have knowledge in Ruby but I want to try to help you on this side (I saw the issue about the language switcher, I will take a look and give it a try on my side)
@TiteiKo, Thank you for the detailed comments, this is a very thorough review.
@TiteiKo Thanks for the review, there was a lot of stupids mistakes that i didn't see before, I'm currently fixing everything
Thank you @BertrandClosset and @TiteiKo! I'm cool with merging this now.
@BertrandClosset do you have a twitter handle I can tag you with when I deploy this?
@DeeDeeG @BertrandClosset @mi-wood You're welcome, glad I could help a bit an important cause. Don't hesitate to ping me on twitter if/when needed 👍
Context
Summary of Changes
fr
folder with all theyml
files translated in french inconfig/locales
config.i18n.available_locales
to add the french language in theapplication.rb
fileChecklist