search

RefugeRestrooms / refugerestrooms

REFUGE restrooms indexes and maps safe restroom locations for trans, intersex, and gender nonconforming individuals.
http://www.refugerestrooms.org
GNU Affero General Public License v3.0
894 stars 261 forks source link

Convert CoffeeScript to JS #456

Closed mi-wood closed 6 years ago

mi-wood commented 6 years ago

It's probably time we solidify around just using JS. CoffeeScript is not a common language to use and it doesn't make sense to have two scripting languages at once (the map views use js for example)

I found https://decaffeinate-project.org/, which probably get's a lot of the easy stuff done, but will require finding what bugs that produces and patching them.

stardust66 commented 6 years ago

I just tried out decaffeinate, and it works, except that it uses ES6, which Phantomjs and older browsers don't support. It's in the "assumptions" section of their conversion guide.

https://github.com/ariya/phantomjs/issues/15287

Introducing ECMA will require nearly-complete rewrite and - keeping in m8ind I seem to be the only active dev of PJS now - will need to wait till other - more urgent - issues are solved.

What do you think about adding Babel so we can use decaffeinate and write more modern javascript while still having tests pass?

mi-wood commented 6 years ago

@stardust66 thanks for getting started on this! I would say go ahead and use babel if that's what you think is best. going to defer to your judgement since you've been working with the js the most

tkwidmer commented 6 years ago

i'm in favor of introducing ES6. This allows us to maybe eventually decouple the two.