Closed nonnullish closed 6 years ago
It may take us some time to find a reviewer, as most of the team has been busy with other responsibilities lately. If we do have any updates for you, we'll post them here. Thanks again for the contribution.
@katafrakt Any chance you could take a look at these translations? :)
Here are the English versions: https://github.com/RefugeRestrooms/refugerestrooms/tree/develop/config/locales/en
@cllns sure, I'm on it
And one more thing: does it make sense to translate text_msg.en.yml
? It's an American and there is no mention that texts should be in English. Maybe it's better to tell users it's not available in their language.
Yeah I messed up the encoding at first. Fixed it now, though. Thanks for the stylistic suggestions :)
Hi again,
Thank you @tusindfryd for making updates/changes, and to @katafrakt for the review! Much appreciated!
I'm going to answer some questions that were raised in comments above.
Why are Twitter and Facebook in
contacts.en.yml
without capital letter?
I think we have "twitter" in lower-case in footer.en.yml
, but everything in contacts.en.yml
looks properly capitalized, unless I missed something. Twitter is un-capitalized for no particular reason, and perhaps we should change it to "Twitter" with capital "T". (I always thought Twitter themselves styled it "twitter," but I see on their website that they use capital "T." 🤷)
If we do change this, it should be updated across other locales as well (which would be easy to do).
. . . does it make sense to translate
text_msg.en.yml
? It's an American and there is no mention that texts should be in English. Maybe it's better to tell users it's not available in their language.
I think this service will work no-matter where you text from? (Maybe there are fees associated with international texting.) I think a warning that texts from this service are in English is a fine idea, though. And maybe a warning that you may be charged texting fees. In which case, a warning regarding language/fees should probably be added to the other locales as well.
This page is not linked to from anywhere, so no-one sees it at the moment. Users would need to know to visit this URL: https://refugerestrooms.org/text
I think we should modify our homepage sometime soon to link to the "texting service" page; With that in mind, keeping the translation up-to-date is a good idea in my opinion. And I think changing the text service page to say it is "unavailable in Poland" is perhaps a more-agressive warning than needed. Open to discussion and feedback from anyone on this. Thanks again.
Hello @tusindfryd,
Thank you for the translation! We will look for another native speaker of Polish to review this, and then we can accept/merge.