RefugeRestrooms / refugerestrooms

REFUGE restrooms indexes and maps safe restroom locations for trans, intersex, and gender nonconforming individuals.
http://www.refugerestrooms.org
GNU Affero General Public License v3.0
894 stars 261 forks source link

Rework restroom-list view to be mobile responsive #483

Closed tymc7 closed 6 years ago

tymc7 commented 6 years ago

Context

Summary of Changes

Checklist

Screenshots

screen shot 2018-06-08 at 11 19 39 pm screen shot 2018-06-08 at 11 19 44 pm screen shot 2018-06-08 at 11 19 49 pm

Before

screen shot 2018-06-08 at 11 47 38 pm

After

screen shot 2018-06-08 at 11 19 39 pm

DeeDeeG commented 6 years ago

This looks really cool, thanks!

I'm going to get it loaded on my machine and try it out.

DeeDeeG commented 6 years ago

One little difference this makes (beside fixing #480) is that is can make the restroom icon rather small in some cases:

280-by-420-screenshot-Firefox-Windows-10

I think it looks fine, and it definitely helps make good use of the screen width without anything overlapping like it used to. I'm in favor, overall.

I love that this is fully responsive, and that the icon takes up just enough space now. And obviously the overlap issue is gone. Also, thank you for making the HTML more semantic by using <ul> and <li> together. 👍

DeeDeeG commented 6 years ago

Another minor change is that it makes margins around the form about 10 or 20 pixels wider on the "Submit a New Restroom" page, but again it looks fine to me.

submit-new-restroom-page-with-wider-margins

DeeDeeG commented 6 years ago

For reasons totally unrelated to this PR, the Travis CI run failed. (It was a network error between Travis and the Gem server, apparently.)

I'm re-starting the Travis CI build -- presumably it will pass this time.

Edit: It passed.

DeeDeeG commented 6 years ago

Will merge soon if there are no objections. 👍