Closed tymc7 closed 6 years ago
This looks really cool, thanks!
I'm going to get it loaded on my machine and try it out.
One little difference this makes (beside fixing #480) is that is can make the restroom icon rather small in some cases:
I think it looks fine, and it definitely helps make good use of the screen width without anything overlapping like it used to. I'm in favor, overall.
I love that this is fully responsive, and that the icon takes up just enough space now. And obviously the overlap issue is gone. Also, thank you for making the HTML more semantic by using <ul>
and <li>
together. 👍
Another minor change is that it makes margins around the form about 10 or 20 pixels wider on the "Submit a New Restroom" page, but again it looks fine to me.
For reasons totally unrelated to this PR, the Travis CI run failed. (It was a network error between Travis and the Gem server, apparently.)
I'm re-starting the Travis CI build -- presumably it will pass this time.
Edit: It passed.
Will merge soon if there are no objections. 👍
Context
.restroom-list
module to be its own moduleSummary of Changes
.restroom-list
code (including@media
queries) to own file.restroom-list
class to be a mobile first by changing all class updates to build on mobile rather than break down from mobile._screen_sizes.scss
to utilize variable listed#list
to be aul
element to be more semantic.restroom-list
viewChecklist
Screenshots
Before
After