RefugeRestrooms / refugerestrooms

REFUGE restrooms indexes and maps safe restroom locations for trans, intersex, and gender nonconforming individuals.
http://www.refugerestrooms.org
GNU Affero General Public License v3.0
894 stars 261 forks source link

Hindi Translations Added under config/locales/hi #503

Closed sankalpchauhan-me closed 5 years ago

sankalpchauhan-me commented 6 years ago

Context

Summary of Changes

Checklist

Screenshots

N/A

Before

After

DeeDeeG commented 6 years ago

Wow, @sankalpchauhan-me thank you for doing this! It has been a while since that issue was posted, I was almost expecting that we might never receive this translation.

I will take a look at the error message at Travis and see what might be the issue, but overall these translations look very good.

Usually we like to have a second native speaker look over any new translation to be sure it is correct. We can look for another person who might be able to review this. Also, if you know someone who might be willing to review and give feedback on the translations, it might speed up the time it takes to review this PR.

Thanks again!

sankalpchauhan-me commented 6 years ago

I have corrected the errors reported by Travis CI, the build is now passing.

DeeDeeG commented 6 years ago

Thank you very much!

All that is left is to find another native speaker of Hindi, so we can review the actual translations. Once such a review has happened, we would be glad to merge. (If for some reason we can't find a reviewer for a long time, we may review using Google Translate just to make sure this can go live at refugerestrooms.org, rather than sitting as a Pull Request forever.)

We appreciate this contribution very much. And happy Hacktoberfest! :jack_o_lantern: :computer: :fallen_leaf: :sparkles:

sankalpchauhan-me commented 6 years ago

Happy Hacktoberfest to you too @DeeDeeG

mi-wood commented 6 years ago

I put out a tweet to see if someone can review this: https://twitter.com/REFUGErestrooms/status/1049416630604689410

DeeDeeG commented 6 years ago

Thank you, @mi-wood!

DeeDeeG commented 5 years ago

Hi @ashishwadekar,

It has been some time since you initially submitted issue #431 to our repository, and someone has now submitted a Hindi translation for Refuge Restrooms. Would you be interested in reviewing this translation for accuracy, and suggesting any improvements you think it needs?

Best regards,

- DeeDeeG

ashishwadekar commented 5 years ago

Hi @DeeDeeG

Sure, I am more than happy to review translation and post my suggestions here.

Cheers, Ashish

ashishwadekar commented 5 years ago

Hi @sankalpchauhan-me @DeeDeeG

The translation looks good to me. बोहोत हि उम्दा काम किया है अपने (You have done a fantastic job)

@sankalpchauhan-me few suggestions to make translation better:

संसाधन पन्ना साइन्स -> प्रतिक

बारे में पन्ना
सरलपुर्वक -> सरलतापूर्वक बच्चे -> व्यक्ति

Also, Please add :hi to config.i18n.available_locales in application.rb

Cheers, Ashish

DeeDeeG commented 5 years ago

Thank you for the review, @ashishwadekar!

sankalpchauhan-me commented 5 years ago

@ashishwadekar @DeeDeeG I have committed the required changes.

DeeDeeG commented 5 years ago

Thanks @sankalpchauhan-me! I should be able to take a look at this within the next couple of days and merge.

DeeDeeG commented 5 years ago

I "deployed" a copy of this branch, so anyone can take a look at it, here: https://refuge-cedar-14.herokuapp.com/

Edit to add: see also https://staging.refugerestrooms.org/

And here is a video capture of what it looks like, also: refugerestrooms-hindi-translation-mp4.zip

ashishwadekar commented 5 years ago

@DeeDeeG @sankalpchauhan-me The changes look good. Cheers 👍

DeeDeeG commented 5 years ago

Alright, it is merged now;,thanks very much to both of you, @sankalpchauhan-me and @ashishwadekar!

sankalpchauhan-me commented 5 years ago

Everything looks good in the deployment, as the PR is merged I am deleting my copy of the branch i.e.sankalpchauhan-me:hindi-translations-develop, I will keep contributing to the project in future. Best Of Luck to everyone working on this project.

sankalpchauhan-me commented 5 years ago

I am a self taught Native Android Developer currently pursuing my Bachelors of Technology in Information Technology @DeeDeeG if there is some Native Android App of this project, I could contribute to that.

DeeDeeG commented 5 years ago

@sankalpchauhan-me we would be happy to have contributions over at our Android app, here: https://github.com/RefugeRestrooms/refugerestrooms-android/ !

We might not be able to review pull requests right away, as our maintainers there are somewhat busy, but contributions are still appreciated, and hopefully we can get to them soon.