Closed hnarasaki closed 5 years ago
Hi again, @hnarasaki.
Generally we would prefer to accept all of these changes all together, in a single pull request.
Here are some steps to make these changes on one branch, so they can be in a single pull request:
patch-1
or Filipino-Staging
[current]
branch. "
As an alternative, we can merge each of these pull requests into a new branch at our repo, probably something like "Filipino-Staging-hnarasaki", until all the files are added/translated. Then we can review all the work and merge that into our main branch.
We're pretty flexible about it, so if one of these options works much better for you we can go with either strategy.
I believe putting all the changes relevant to a given issue into one branch, and then starting a single pull request for all the changes, is the typical way on GitHub. But we would rather accept the contribution as several pull requests than insist on receiving them any particular way.
(I hope the step-by-step instructions I put together above are okay, as I couldn't think of better way to express what we are looking for.)
I will wait until hearing back from you (or else a day or so if we don't hear back from you) before merging these pull requests as-is.
Thanks again for working on this.
Okay, I am merging these pull requests. :+1:
We do not need the file "en.yml" so I will close this pull request.
@DeeDeeG Thanks for the explanation on this, it was helpful and I really appreciate it! :)
I believe this file will not be translated
Context
Filipino Translation https://github.com/RefugeRestrooms/refugerestrooms/issues/451
Summary of Changes
Added file.