Closed btyy77c closed 4 years ago
Travis CI error is unrelated to these changes. Thank you! Overall this looks good!
In my practical testing, all of the site's functionality that I can test in Docker was working.
Key things that were checked:
Not checked (I don't know how to check these at this time):
I'm going to merge this, despite the failing tests, because (as you have pointed out, and I have confirmed) these same tests pass on the develop
branch, on commits that previously passed. As such, these changes did not cause the tests to fail.
I will make some tweaks to follow up on this PR, as mentioned in my review comments.
(Please note that we have recently changed the merge policy to use only "squash" merges. So, for the time being, this and all future Pull Requests will be squashed into a single commit when merged.)
Thank you for doing this upgrade!
Context
Summary of Changes
Checklist
Screenshots
Before
After