Closed Joranhezon closed 3 years ago
It seems that deleting the file won't solve the problem, since it breaks the app.
@Joranhezon thanks for trying this. I will look at what changed and try to understand.
The other maintainers have set up this part of the app, so I am a bit behind on knowledge of this area.
(As always, @tkwidmer @mi-wood if you know the answer to this one, and you have a free bit of time, feel free to elucidate!)
Will keep trying to get to the bottom of it. :+1:
There is also #626, which may be a real solution. But by trying something more dramatic, hopefully the errors will shed light on the technical details of why we need (or don't need?) these variables.
Continuous integration tests passed, https://travis-ci.com/github/RefugeRestrooms/refugerestrooms/builds/175162554, so I think if there are problems they are in areas that we don't have tests for.
I have found that without this .env
file, the RECAPTCHA_SITE_KEY
and RECAPTCHA_SECRET_KEY
environment variables are unset, and recaptcha no-longer works in local testing with Docker.
(Apparently these keys are set to work on localhost
only, so having them out in the open is not a concern, with regard to someone potentially abusing these keys.)
Given that there is some usefulness to this file, I am planning to keep it for the time being. Thanks again for taking an interest and helping to look into this. As a late-comer to this project, I am always learning more about its codebase. This helped me understand why we need this file. 👍
Closing, as it turns out we want to keep this file after all.
Context
Summary of Changes
Checklist
Screenshots
After
Before