RefugeRestrooms / refugerestrooms

REFUGE restrooms indexes and maps safe restroom locations for trans, intersex, and gender nonconforming individuals.

http://www.refugerestrooms.org

GNU Affero General Public License v3.0

891 stars 263 forks source link

Delete .env file to investigate it's impact on project (#624) #632

Closed Joranhezon closed 3 years ago

Joranhezon commented 4 years ago

Context

Fixes #624
Delete .env file to investigate it's impact on project.

Summary of Changes

Delete .env file.

Checklist

[ ] Tested Mobile Responsiveness
[ ] Added Unit Tests
[ ] CI Passes
[ ] Deploys to Heroku on test Correctly (Maintainers will handle)
[ ] Added Documentation (Service and Code when required)

Screenshots

After

Screenshot from 2020-07-10 10-53-10

Before

Screenshot from 2020-07-10 11-01-10

Joranhezon commented 4 years ago

It seems that deleting the file won't solve the problem, since it breaks the app.

DeeDeeG commented 4 years ago

@Joranhezon thanks for trying this. I will look at what changed and try to understand.

The other maintainers have set up this part of the app, so I am a bit behind on knowledge of this area.

(As always, @tkwidmer @mi-wood if you know the answer to this one, and you have a free bit of time, feel free to elucidate!)

Will keep trying to get to the bottom of it. :+1:

DeeDeeG commented 4 years ago

There is also #626, which may be a real solution. But by trying something more dramatic, hopefully the errors will shed light on the technical details of why we need (or don't need?) these variables.

DeeDeeG commented 4 years ago

Continuous integration tests passed, https://travis-ci.com/github/RefugeRestrooms/refugerestrooms/builds/175162554, so I think if there are problems they are in areas that we don't have tests for.

DeeDeeG commented 3 years ago

I have found that without this .env file, the RECAPTCHA_SITE_KEY and RECAPTCHA_SECRET_KEY environment variables are unset, and recaptcha no-longer works in local testing with Docker.

(Apparently these keys are set to work on localhost only, so having them out in the open is not a concern, with regard to someone potentially abusing these keys.)

Given that there is some usefulness to this file, I am planning to keep it for the time being. Thanks again for taking an interest and helping to look into this. As a late-comer to this project, I am always learning more about its codebase. This helped me understand why we need this file. 👍

DeeDeeG commented 3 years ago

Closing, as it turns out we want to keep this file after all.