DeeDeeG
commented
3 years ago This (or similar) should be the commit text when squashing and merging:
* Finish Upgrading Webpacker to v5 (#637)
- Gemfile[.lock]: Update webpacker to 5.2.1
- Webpacker: Update config files
Ran "rails webpacker:install" and committed the changes.
In "config/webpacker.yml,"
kept the ".js.erb" entry under "extensions:"
so that "app/javascript/packs/lib/maps.js.erb" is included.
In "config/webpack/environment.js,"
kept jQuery and rails-erb-loader configs,
as we are still using these.
- JS dependencies: Upgrade webpack-dev-server
Commit the changes from running `rails webpacker:install`,
but using a caret "^" semver range for "@rails/webpacker",
rather than an exact version.
(So that we get updates in the 5.x series)
* Update dependencies for September 2020 (#636)
- dependencies: Remove `swagger` node module
We don't actually use this.
Also removes 200 sub-dependencies,
and makes our yarn.lock file about 1270 lines shorter!
- yarn.lock: Upgrade bootstrap to 4.5.2
(Was at version 4.4.1)
- dependencies: Resolve node-fetch to ^2.6.1
- yarn.lock: Upgrade "selfsigned" and "node-forge"
- Gemfile[.lock]: Update Rails and dependencies
rails was 5.2.4.3, now it's version 5.2.4.4
* Keeping filters state on pagination (#638)
- Keeping filters state on pagination
- Fix Code Climates complaints.
- Fixed active issue on ada filter buttons
- Fixed undefined function problem when run rspec.
* Add rubocop and resolve lint errors (#644)
- Initialize rubocop
- Run rubocop with --fix
- Don't require magic comment
This will affect every file and have potential side effects, so I'm
going to start with this turned off.
- Resolve lint errors in `app`
- RSpec linting
- Resolve remaining
- Fix wrong change
- Singleton method for verify
- New lint rules
- Add rubocop to travis config
- Correct docker compose command
- Check for geo
The condition was actually supposed to be `if geo = results.first`,
because that's not always obvious the intention and fails lint, I'm just
doing a truthy check for it which should be the same.
- Fix typo
- Add contributing docs for rubocop
* Applying ADA filters for the Map view of search. (#651)
- Applying ADA filters for the Map view of search.
- Changed comment for polyfill URLSearchParams
- Fixed bug of map marker content not showing.
* Add a standard EditorConfig configuration for every contributor to follow (#649)
* Enhancement/i18n thread safe (#647)
- Provide a way to respond requests without thread-safe issues
As rails docs says https://guides.rubyonrails.org/i18n.html#managing-the-locale-across-requests
When we use 'I18n.locale =' the current locale could leak into following requests
this is a standard and recommended way to deal with it :)
- Create a shared_example to test I18n locale switching
- Update spec/controllers/pages_controller_spec.rb
* Upgrade puma to latest version 5.x (#641)
* yarn.lock: Update "http-proxy" to v1.18.1 (fe195d7)
Co-authored-by: Lucas <torres.giorgio@gmail.com>
Co-authored-by: Tegan Rauh <3896310+tegandbiscuits@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Note
Thank you to new contributors @brunoocasali, @GPrimola and @tegandbiscuits!
Happy Hacktoberfest!
Changelog
Bruno Casali (3): Add a standard EditorConfig configuration for every contributor to follow (#649) Enhancement/i18n thread safe (#647) Upgrade puma to latest version 5.x (#641)
DeeDeeG (3): Finish Upgrading Webpacker to v5 (#637) Update dependencies for September 2020 (#636) yarn.lock: Update "http-proxy" to v1.18.1 (fe195d72d55b8eadcb0d7b0a757036e998e3bf05)
Lucas (2): Keeping filters state on pagination (#638) Applying ADA filters for the Map view of search. (#651)
Tegan Rauh (1): Add rubocop and resolve lint errors (#644)
Checklist