Add a locale switcher, second try

[DeeDeeG]

Context

• Finishes the work started in #585 and continued in #620
• Fixes #428
• Adds a locale switcher to the site footer, rewires some of application_controller.rb to add locales to dynamic links, and set the current locale based on the URL parameter if present. Updates hard-coded links within the app to dynamic ones.

Summary of Changes

• Add a default URL parameter, locale that will appear as ?locale=[your-locale-code-here] in the URL. For example: /restrooms/new?locale=es is the "Add a New Restroom" page, explicitly in Spanish.
  • Dynamically generated links, such as the ones made with Rails' helpers (for example: link_to), automagically use the URL parameter ?locale=[some_locale_here] now.
• Use dynamically-generated links throughout the site, replace hard-coded links with dynamically-generated ones.
• Add locale-switching links to the footer, approach inspired by the footer at https://rubygems.org
• Enable optional routing to locale-prefixed versions of most URLs in the app. For example: /fr/restrooms/new is the "Add a New Restroom" page, explicitly in French. (Disabled for now, as this wasn't working as intended.)

Checklist

• [x] Tested Mobile Responsiveness
• [ ] Added Unit Tests
• [x] CI Passes
• [ ] Deploys to Heroku on test Correctly (Maintainers will handle)
• [ ] Added Documentation (Service and Code when required)

Screenshots

Before

After

[DeeDeeG]

Hi @brunoocasali, I hope you are doing well.

I've been working on finishing the locale switcher feature for Refuge Restrooms. I think it's ready now!

If you are interested in helping with adding tests for locales other than English, I think this could be a reasonable place to do that. It would, of course, be much appreciated.

Best Regards,

- DeeDeeG

[DeeDeeG]

@brunoocasali I added the changes you suggested, matching the Rubocop-linted style.

During testing, I found out that there is a problem still. Might you be able to help troubleshoot this?

When starting a new search for restrooms using the search bar, the locale parameter is not preserved. It appears to me that the search results page is generated only with the following parameters (with the example search "San Francisco").

/restrooms?utf8=✓&lat=37.7749295&long=-122.4194155&search=san+francisco

• utf8
• lat
• long
• search

But no locale parameter.

It's not immediately clear to me how these parameters are generated, as I'm not familiar with that part of the codebase. (I suspect it might be part of Refuge Restrooms' JavaScript code, but I'm not sure.) If I knew where these were generated, then perhaps it would be easier to ensure the locale parameter was preserved there, too, if set.

[brunoocasali]

@DeeDeeG I could help you with this tomorrow, okay? :)

[DeeDeeG]

That would be great!

I'm getting more confident that it's in app/javascript/packs/lib/ --> geocoder.js or maps.js.erb. Not totally sure, though.

[brunoocasali]

@DeeDeeG checkout the #657 ;)

[DeeDeeG]

Thanks for reviewing/merging #657, @tkwidmer.

I think the last thing for me to do on this is to check the "new restroom" submission process works properly with these locale switchers. I would like to do the dependency bumps first and get those out as a patch release.