RefugeRestrooms / refugerestrooms

REFUGE restrooms indexes and maps safe restroom locations for trans, intersex, and gender nonconforming individuals.
http://www.refugerestrooms.org
GNU Affero General Public License v3.0
892 stars 262 forks source link

Replace kaminari with pagy #681

Closed amadayami closed 1 year ago

amadayami commented 1 year ago

Context

Checklist

Screenshots

Before

Screen Shot 2023-05-23 at 20 21 01

After

Screen Shot 2023-05-23 at 20 19 58

amadayami commented 1 year ago

The check failed after the CI errored in the build phase. Would someone be able to rerun the check? Thanks 😄

DeeDeeG commented 1 year ago

Hi @amadayami,

I resolved the main issue (where tests were not getting to run at all) on our main develop branch. With that change on this branch, I assume all but one test would pass, since it seems to rely on the Google Maps API working, and there's a bit of a quota or billing issue with that at the moment that's affecting the main site as well.

(Other maintainers have access to the Google API dashboards, and I don't, so I can't do anything about that personally, though I have pinged the other maintainers.)

Anyhow, if you'd like to rebase on, or merge develop branch to this one, that should get CI mostly working again. (I can rebase or merge it for you, if you rather a maintainer take care of it.) And if it's the same one failure as we're seeing on develop branch right now, then I'd know it isn't this particular PR's fault.

amadayami commented 1 year ago

Hi @DeeDeeG I have merged my branch with the updated develop branch and had no merge conflicts. I addressed the rubocop issues, but the one error you mentioned was still popping up (./spec/features/restrooms_spec.rb:45).