RefugeRestrooms / refugerestrooms

REFUGE restrooms indexes and maps safe restroom locations for trans, intersex, and gender nonconforming individuals.

http://www.refugerestrooms.org

GNU Affero General Public License v3.0

888 stars 262 forks source link

Fix rails-ujs import syntax causing thumbs up/down buttons to not work #694

Closed mmx900 closed 2 months ago

mmx900 commented 2 months ago

Context

Currently there is __webpack_require__(...).start is not a function error in the JavaScript console. This error seems to have appeared after a recent upgrade to Rails 7. If I downgrade rails-ujs to 6.x, the error disappears. Additionally, it seems to break some functionallity that uses rails-ujs. This PR fixes the error and adds tests to prevent regression, as there were no existing tests for this functionality.

Summary of Changes

Fix js error by following current documentation of rails-ujs.
Add missing specs to prevent regression and ensure the voting functionality works as expected.

Checklist

[ ] Tested Mobile Responsiveness
[x] Added Unit Tests
[x] CI Passes
[ ] Deploys to Heroku on test Correctly (Maintainers will handle)
[ ] Added Documentation (Service and Code when required)

Screenshots

Before

After