search

RefugeRestrooms / refugerestrooms

REFUGE restrooms indexes and maps safe restroom locations for trans, intersex, and gender nonconforming individuals.
http://www.refugerestrooms.org
GNU Affero General Public License v3.0
892 stars 262 forks source link

JS clientside geocoding doesn't seem to be working in development #99

Closed tkwidmer closed 10 years ago

tkwidmer commented 10 years ago

screen shot 2014-04-01 at 6 14 35 pm when a search is performed this is what happens. note in the address bar there is no lat/long data being passed.

backspace commented 10 years ago

The pull request fixes the problem, but more generally, I recommend developing a testing process that automatically exercises each feature of the application so any bugs introduced by new commits are caught before being merged. Since this is an open source project, we could use Travis CI, which would automatically run all tests on every merge request and get feedback about whether anything broke.

On other projects, I’ve used Cucumber to write high-level tests that ensure each desired feature of the application works. For instance:

Feature: Search restrooms

  Background:
    Given a restroom exists in Montréal
    And a restroom exists in Winnipeg

  Scenario: Search from splash page
    When I am on the splash page
    And I search for "Montréal"
    Then I should see a restroom

  Scenario: Search from header
    When I am on the splash page
    And I search for "Montréal"
    Then I should see a restroom
    When I search for "Winnipeg"
    Then I should see a restroom

Cucumber is not beloved by all and I’m open to suggestions, but regardless, I think some amount of testing to ensure bugs aren’t silently introduced to the codebase would be helpful, especially with so many people contributing.

I’m planning to be in town for the hackathon, so if there’s any interest in getting some automated testing going, I could work on that there.

mathonsunday commented 10 years ago

I second using Travis CI.

I agree that we really need tests and am happy to contribute some. I don't have a strong preference for which framework we use.

f3ndot commented 10 years ago

:+1: for Travis CI

And I'm happy to contribute tests too

Sent from mobile. On Apr 2, 2014 1:08 AM, "mathonsunday" notifications@github.com wrote:

I second using Travis CI.

I agree that we really need tests and am happy to contribute some. I am not familiar with testing in Rails and thus have no opinion on which framework to use.

Reply to this email directly or view it on GitHubhttps://github.com/tkwidmer/refugerestrooms/issues/99#issuecomment-39289347 .

backspace commented 10 years ago

Hey :thumbsup:ers, check out the linked pull request for preliminary Travis CI integration. I can work on some preliminary acceptance tests in a separate branch. Exciting!