search

Regalijan / omniauth-roblox

OmniAuth strategy for Roblox
MIT License
0 stars 0 forks source link

This gem generally breaks all over the place #1

Open brianewell opened 4 months ago

brianewell commented 4 months ago

Good morning,

I'm having some pretty serious issues with using this gem.

Initially I attempted to utilize the gem as you've documented:

config/initializers/omniauth.rb:

Rails.application.config.middleware.use OmniAuth::Builder do
  provider :roblox, Rails.application.credentials.oauth.roblox.id, Rails.application.credentials.oauth.roblox.secret, scope: 'openid profile'
end

Produced the following Authorization Error from Roblox:

RouterParamMissingOrInvalid: scope The supplied query is malformed. Please contact the creator of the application for help.

It seems that this is being caused by a failure to pass the scope data along to roblox. After addressing that in a fork, I found additional significant issues preventing my use of this gem. Would love some help here.

Regalijan commented 4 months ago

Yeah I never got to use it much since the project it was being made for was canned (and never was tested as a result)

I'll start fixing it up though since now I know someone is actually trying to use it.

That said I'm on vacation and will be until the 30th so I'm not sure how much I'll be able to do short-term.

brianewell commented 4 months ago

Completely understandable.

I've been trying to grok various oauth2 strategies to put something together that would work for my purposes. The omniauth-discord strategy is very cleanly written, and I've been trying to work from that, but it's been difficult.

Regalijan commented 3 months ago

Status update here:

It's in a better off state now (although not 1.x ready) and seemed to at least work enough for my dummy rails app during testing.

I'm not really sure what else you are looking for though, although I have a better idea of my schedule now so I can hopefully allocate time to this better.

brianewell commented 3 months ago

From upstream organizational requirements, we have re-implemented roblox oauth2 support from scratch. This is available in the following repo: https://github.com/super-dimension-studios/omniauth-roblox Feel free to integrate whatever makes sense to.