Regalis11 / scpcb

SCP - Containment Breach
374 stars 107 forks source link

Please fix bugs related to map creator #246

Closed nasuccc closed 1 year ago

nasuccc commented 1 year ago

BUG: room2_2 1048-A corruption GAME IMPACT: High-Gamebreaking FIX DIFFICULTY: Low (just removing the event) - High (fixing the event) MAP CREATOR EXCLUSIVE: Possibly DESCRIPTION: This bug happens in room2_2 (the giant fan room). When the room2_2 event is selected as "1048a" instead of "room2fan" strange things will start to happen. An example is a giant fan spawning inside the facility. There is a possibility this bug can cause the game to crash. 1048-A also appears to not spawn in the room.

BUG: 372 doesn't spawn GAME IMPACT: Medium FIX DIFFICULTY: Low-Medium MAP CREATOR EXCLUSIVE: Yes DESCRIPTION: 372 doesn't spawn in custom maps. When I tested it the event in the room it appears in (called "roompj") was set to 100%.

Other problems:https://undertowgames.com/forum/viewtopic.php?t=11044

nasuccc commented 1 year ago

Giant fan Placing room2_2 next to room2_3 and setting events to "1048-a" will cause this error to occur. Error log for the giant fan: An error occured in SCP - Containment Breach! Version: 1.3.11 Save compatible version: 1.3.11 Date and time: 31 Mar 2023 at 19:56:10 Total video memory (MB): -1 Available video memory (MB): -208 Global memory status: -1192 MB/-1 MB (-1220268 KB/-1 KB) Triangles rendered: 46742 Active textures: 255

Error(s): "1048a" event *** SetAnimTime: Entity has no animation

theOneTrueFunniBoi commented 1 year ago

The game uses the first object assigned to the room (0), as 1048a, the only problem is in the fan room, the fan is object 0, so the game ends up manipulating the fan instead of 1048a. Basically the fan becomes 1048a. Im not sure how to fix it though.

Edit: Adjusted Wording.

ChronoQuote commented 1 year ago

These issues are caused by mistakes in Data\events.ini. I will try to submit a PR with fixes later.

Regalis11 commented 1 year ago

Fixed in https://github.com/Regalis11/scpcb/pull/253