krabecb
commented
1 year ago Excellent work on P3! I love this app idea! 🙌🏽
Here are some things Joshua and I observed:
- [ ] README could have detailed information about what to expect throughout the application
- [x] API proxy
- [x] Marvel api integration
- [ ] Images are stretched on search results page
- [x] Image not stretched on detail page
- [ ] Could have auth to ‘favorite’ certain characters which could be saved (cached)
- [ ] JWT for post-GA is a must!
Reflection - create an issue (one for each team member) that reflect how you handled the workflow/complexities/challenges of P3. What went well? What lessons will you take away from the experience? Nothing went well at first. It's not until constant reevaluations and analysis did things go well. What I I will take away that I didnt know before is, how to interact with an api and how use MERN stack.
Is there anything about your efforts/workflow you want to reproduce in future projects? definitely want to reproduce how soon I started working on my project. II started as soon as I received the directions. Which allowed me to deal with the most difficult portion of the application right away.
What did not go so well? Were there any events/obstacles that blocked you or impeded your team’s progress? During the weekend, I had to work 2 double shifts which resulted in my not having any time to create functions that do something outside of GET requests. For example, user creations.
What will you do to prevent the above issue from occurring in a future project/collaboration. Not entirely sure.