search

RegioHelden / django-kafka

MIT License
2 stars 1 forks source link

kafka_skip is overridden with get_or_create/update_or_create/create #14

Closed stefan-cardnell-rh closed 3 weeks ago

stefan-cardnell-rh commented 1 month ago

The following patterns do not work:

Model.objects.create(kafka_skip=True)
Model.objects.update_or_create(..., defaults={'kafka_skip': True})
Model.objects.get_or_create(..., defaults={'kafka_skip': True})

because underneath these methods do not use update_fields, and so our logic in KafkaSkipMixin overrides our desired setting of kafka_skip to False

Also consider whether KafkaSkipMixin should be renamed to KafkaSkipModel