search

RegioHelden / django-scrubber

Anonymizer for Django database data
Other
25 stars 10 forks source link

Properly delete fake cache before provisioning #14

Closed mastacheata closed 4 years ago

mastacheata commented 4 years ago

We seem to have forgotten changing the delete query to also use the provider_key. Right now it's looking for self.provider and won't find anything to delete, which in turn will cause an error with the UniqueConstraint for provider/provider_offset

fixes #16

mastacheata commented 4 years ago

Hmm, seems like I should rebase my branch again.

costela commented 4 years ago

Thanks @mastacheata, LGTM. But could you please rebase your changes onto master?

mastacheata commented 4 years ago

Thanks @mastacheata, LGTM. But could you please rebase your changes onto master?

Just did that. It just seems our branches have diverged too much? I'll try something stupid and create a new clean branch from your matser and will only apply the 4 commits I did for this issue.

mastacheata commented 4 years ago

It looks like Github might have a problem picking up with what I did just now.

created a new branch from master cherry-picked the 4 commits in this new PR squashed them in pairs of 2 so my mistake-fix combos would appear as only one commit each

The result should be my branch being ahead of your master by 2 commits.

OK, I rebased my own master on your master and pushed everything, now it seems to have picked up my changes.