search

RegrowthStudios / Vorb

Regrowth Studios Vorb Engine
MIT License
60 stars 29 forks source link

Hunter's Yaml-CPP Version Can't Compile In VS2017 #116

Open MatthewJM96 opened 5 years ago

MatthewJM96 commented 5 years ago

We need to keep an eye on yaml-cpp for its next release. When it releases we then need to get Hunter to accept that new version as an option for building with. This will enable compilation on VS2017.

Alternatively, we could heed the issues raised by Cristian in this issue and look for an alternative yaml solution.

czaloj commented 5 years ago

Yeah, I don't remember what the exact problem was with it :/

caseymcc commented 5 years ago

or better yet who needs yaml, I will gladly replace it with json

caseymcc commented 5 years ago

In fact, I have already been working on python scripts to convert the current texture yaml files to json, for my needs.

Barnold1953 commented 5 years ago

+1 for json

MatthewJM96 commented 5 years ago

Did we not prefer YAML for the ease of understanding for modders and designers? If it makes life significantly easier then JSON gets a +1 from me on that reason, but as it stands yaml-cpp is only preventing compilation on VS2017 due to a single macro - could we not make a request to the yaml-cpp guys to back-propagate their hotfix for that to a new minor release for 0.5?

MatthewJM96 commented 5 years ago

I definitely prefer the yaml format on grounds of the end-user.

Barnold1953 commented 5 years ago

yeah we picked YAML for ease of use, and robustness. It is probably better for our needs so if we have a reliable parsing alternative or a way to fix this then its ideal.

MatthewJM96 commented 5 years ago

I'll make a PR with the yaml-cpp guys/get in touch with them, however they prefer, we can come back to thinking about changing after we know how easy they make it for us to get what we need.

bryan-lunt commented 4 years ago

Also cant compile on MacOS.